Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Upgraded Seismic Stomp Visual Behavior, issue 2125/2126 #2510

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Fix for Upgraded Seismic Stomp Visual Behavior, issue 2125/2126 #2510

merged 11 commits into from
Oct 17, 2023

Conversation

xTammaro
Copy link
Contributor

Fix for Upgraded Seismic Stomp Visual Behavior

This fixes issue #2125 and potentially #2126. The new visual behaviour for Seismic Stomp upgraded ability:

Screen.Recording.2023-10-16.at.2.12.14.pm.mov

The changes include:

Only filling in the hexes of the creature that is hovered

Showing dashed hex for empty hexes

Cancelling the ability upon clicking the empty hex.

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Oct 17, 2023 4:47am

@xTammaro xTammaro changed the title Issue 2125 Fix for Upgraded Seismic Stomp Visual Behavior, issue 2125/2126 Oct 16, 2023
@ghost
Copy link

ghost commented Oct 16, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@DreadKnight
Copy link
Member

DreadKnight commented Oct 16, 2023 •
edited
Loading

@xTammaro Heya! Did a bit of testing and found some issues:

  • clicking path leading to first unit should trigger attack (see non-upgraded version or other ranged abilities)
  • don't show multiple cancel cursors
    Screenshot_20231016_180152

@DreadKnight DreadKnight marked this pull request as draft October 16, 2023 15:03
@xTammaro
Copy link
Contributor Author

I have fixed both issues!
Only one cancel cursor is shown, and only for hexes after the first creature in the path:
Screenshot 2023-10-17 at 12 40 30 pm

Also hovering over this first empty hex will only highlight the first creature, and clicking on it will attack the first creature:

Screenshot 2023-10-17 at 12 38 22 pm

Let me know if anything else needs tweaking, otherwise I think this should work as expected!

@xTammaro xTammaro marked this pull request as ready for review October 17, 2023 02:16
@xTammaro
Copy link
Contributor Author

Sorry I have found an issue, this is not ready.

@xTammaro xTammaro marked this pull request as draft October 17, 2023 04:15
@xTammaro
Copy link
Contributor Author

The issue is fixed, now works with multi-directional targets:

Screenshot 2023-10-17 at 3 46 59 pm

@xTammaro xTammaro marked this pull request as ready for review October 17, 2023 04:48
@DreadKnight
Copy link
Member

@xTammaro Looks good to me. Well done! 👍🏻

@DreadKnight DreadKnight merged commit c784cc8 into FreezingMoon:master Oct 17, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xTammaro @DreadKnight